mayastor
mayastor copied to clipboard
openebs
ZNS support
This draft PR addresses the issue https://github.com/openebs/mayastor/issues/1297 and shall encourage discussion. This should not be merged as is as there are two dependencies that need to be resolved before this can potentially be merged:
- The OpenEBS fork of spdk needs a branch for v23.01 similar to https://github.com/MaisenbacherD/spdk/commits/wip-v23.01.x-mayastor when v23.01 is released.
- The draft PR https://github.com/openebs/spdk-rs/pull/24 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly
Hi @MaisenbacherD - I believe that SPDK v23.01 is now integrated into Mayastor.
@tiagolobocastro can you confirm that SPDK v23.01 is now the current default base SPDK version in the product?
Hi @MaisenbacherD I just chatted with @tiagolobocastro and he clarified that we will be updating to the latest release of SPDK soon, which is v24.01. and that we are already at v23.01 as of now.
Hi @orville-wright Thanks for confirming! This draft was rebased onto the develop branch when SPDK v23.01 was already picked up by you - so the SPDK version requirement is fulfilled :)
Let me know if there is something else I can do.
haven't finished, will resume tomorrow
@tiagolobocastro Thanks so far! I will address your comments soon after you are done :)
hi @MaisenbacherD it looks like all the requested reviewers have given significant feedback on the PR. So you should have lots of guidance on moving this project forward now. Let me know of you need any more assistance. Happy to help.
Thanks everyone for the reviews! I am addressing your comments in the following days :)
hi @MaisenbacherD - checking in here on where things are on the project?
- let's talk to see how we can move this forward
hi @MaisenbacherD - checking in here on where things are on the project?
- let's talk to see how we can move this forward
Hi @orville-wright. My apologies for the delay! I was sidetracked by other projects again. I am making sure to allocate time to work on the comments in the next week as I am offline for the rest of the week :)
Thanks @MaisenbacherD - We are very grateful that you have taken the time and effort to enhance openEBS with such an innovative feature. Your contribution to the project & the community is very valuable and very appreciated. It makes openEBS even better for everyone.
We also appreciate that an industry respected storage innovator (WD.com) supports openEBS with their resources & your time/expertise. Thank you WD.com
The team will review and pass on comments. Great progress.
Hi @orville-wright,
Apart from the review comments, would it be possible to get some help with enabling the latest btrfs, libnvme and nvme-cli nix packages? I am not that fluent in nix yet. :)
Sure thing. I'll loop get you connected with the right people on the team.
Hey @tiagolobocastro @niladrih and @Abhinandan-Purkait - Dennis @MaisenbacherD needs some eng help with some of the packages... specifically btrfs, libnvme and nvme-cli nix. He's said that he's not that fluent in nix yet.
- Since this is an important community / partner led feature... can you guys sync up with Dennis and let's see if we can help him out.
- We really need to get this awesome ZNS feature coded & released.
~Dave
Sure. FYI, btrfs support has already been added to mayastor, We just need to specify fstype: btrfs in storage class to have brtfs filesystem volumes backed by mayastor.
Hi @MaisenbacherD looks like some feedback was given by @Abhinandan-Purkait , but I'm not sure if he provided enough of the info you needed ?
@orville-wright, @Abhinandan-Purkait great! I was not aware that btrfs is already an option :)
The current libnvme and nvme-cli nix packages in use look outdated. I would need help to get the latest nix upstream packages configured. I am not sure that adjusting e.g. nix/pkgs/nvmet-cli/default.nix is the correct way to do that :)
@orville-wright, @Abhinandan-Purkait great! I was not aware that btrfs is already an option :)
The current libnvme and nvme-cli nix packages in use look outdated. I would need help to get the latest nix upstream packages configured. I am not sure that adjusting e.g.
nix/pkgs/nvmet-cli/default.nixis the correct way to do that :)
To be honest, you can probably just remove the specific files we've got for those, and just rely on the versions from nixpkgs. Otherwise you can edit those files to pull the latest versions you need.
@MaisenbacherD sorry for short notice, would you be able to join our community meeting today: https://us05web.zoom.us/j/87535654586?pwd=CigbXigJPn38USc6Vuzt7qSVFoO79X.1 It's at 2pm UTC