lvm-localpv icon indicating copy to clipboard operation
lvm-localpv copied to clipboard

use ResourceList for capacity

Open pawanpraka1 opened this issue 4 years ago • 3 comments

Describe the problem/challenge you have

Currently capacity is string. We should move towards ResourceList to store the capacity.

pawanpraka1 avatar Dec 31 '20 05:12 pawanpraka1

Unsure of reasons behind needing this. Checking if it's not something that will have side-effects or breaking behaviour.

dsharma-dc avatar Jun 03 '24 17:06 dsharma-dc

This pertains to changing the type of Capacity in VolumeInfo.

// VolumeInfo defines LVM info
type VolumeInfo struct {

[...]

	// Capacity of the volume
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:MinLength=1
	Capacity string `json:"capacity"`

dsharma-dc avatar Jun 24 '24 17:06 dsharma-dc

This needs to be consistent across all engines. Need to assess the impact of this modification.

avishnu avatar Sep 12 '24 09:09 avishnu