lvm-localpv icon indicating copy to clipboard operation
lvm-localpv copied to clipboard

[WIP] feat(shared-vg) : add support for create, delete, publish & unpublish of shared volumes

Open Ab-hishek opened this issue 3 years ago • 1 comments

Signed-off-by: Abhishek Agarwal [email protected]

Why is this PR required? What issue does it fix?: This PR addresses the issue of adding support for creating volumes LVM2 shared volume groups.

What this PR does?: Add new features for volumes on top of shared volume groups. This PR adds support for the following workflows:

  1. Creating an exclusively shared volume on shared volume group.
  2. Deleting an exclusively shared volume on shared volume group.
  3. Publishing(mounting) an exclusively shared LVM volume onto a pod.
  4. Unpublishing(unmounting) an exclusively shared LVM volume.

NOTE:

  1. This PR only adds support for exclusively shared LVM volume.
  2. Features such as volume expanding and volume snapshots are not supported for exclusively shared LVM volumes.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered:: Testing is yet to be done

Any additional information for your reviewer? : Design doc for this PR: https://docs.google.com/document/d/1QJUPW3C8DSSwRkCjgh_O472KfZcgTnU9/edit?usp=sharing&ouid=106351714067742402436&rtpof=true&sd=true

Checklist:

  • [x] Fixes #134
  • [x] PR Title follows the convention of <type>(<scope>): <subject>
  • [ ] Has the change log section been updated?
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests
  • [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • [ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Ab-hishek avatar Apr 06 '22 12:04 Ab-hishek

@Ab-hishek can you please add the details about how much testing has been done and what part needs to be tested yet.

pawanpraka1 avatar Apr 08 '22 12:04 pawanpraka1

The implementation of this change resulted in unknown and complex scenarios. It's been decided after consulting the original author of the PR, that we can close this PR. If any one is interested to continue the shared-vg feature development, please feel free to re-open and refer the code.

avishnu avatar Aug 23 '23 05:08 avishnu