node-disk-manager icon indicating copy to clipboard operation
node-disk-manager copied to clipboard

NDM should watch for ConfigMap changes

Open kmova opened this issue 6 years ago • 1 comments

NDM DaemonSet pods use the ConfigMap to determine what disks are discovered and added as disk resources. This configuration is read at the startup by the DaemonSet Pods.

What is the expected behavior? It will be good to have the pods watch for the ConfigMap changes and dynamically (at runtime) change the logic for types of disks discovered.

This also requires the NDM to handle cases, where some of the disks that were discovered with previous config to be deleted, if the new config restricts them.

kmova avatar Jan 01 '19 18:01 kmova

When managing the install with helm, this trick can be used: https://github.com/helm/charts/blob/master/stable/cerebro/templates/deployment.yaml#L29 as a change in configmap will trigger a change in annotation which again triggers a rollout.

davidkarlsen avatar Mar 20 '20 09:03 davidkarlsen