jiva-operator icon indicating copy to clipboard operation
jiva-operator copied to clipboard

chore(helm): Adds custom iSCSIadm ConfigMap and HostPID options

Open leosunmo opened this issue 1 year ago • 0 comments

Why is this PR required? What issue does it fix?: Fixes #207

What this PR does?: Adds the ability to enable HostPID: true for the csi Node DaemonSet. It also adds the ability to inject a custom configuration in to the hardcoded openebs-jiva-csi-iscsiadm ConfigMap.

These changes are pretty small but ensures that the Jiva Operator can more easily be used with (Talos)[https://www.talos.dev/]. Talos requires some modifications for it to work properly with Talos. Details here: https://www.talos.dev/v1.6/kubernetes-guides/configuration/replicated-local-storage-with-openebs-jiva/#patching-the-jiva-installation

Does this PR require any upgrade changes?: No, it's only Helm Chart changes.

If the changes in this PR are manually verified, list down the scenarios covered:: I ran helm template locally with the two added variables provided and left blank to make sure the behaviour makes sense.

Any additional information for your reviewer? : I did not touch the chart version, as it seems you keep it in lock-step with the actual Jiva Operator version, so I left that up to you guys. I'm happy to bump the version (3.6.1 for example) before merging if that's easier though. I also did not add anything to the CHANGELOG.md file for the same reason.

Checklist:

  • [ ] PR Title follows the convention of <type>(<scope>): <subject>.
  • [ ] Has the change log section been updated?
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests
  • [ ] (Optional) Does this PR change require updating Helm Chart? If yes, mention the Helm Chart PR #<PR number>
  • [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • [ ] (Optional) If documentation changes are required, which issue https://github.com/openebs/website is used to track them:

leosunmo avatar Dec 28 '23 16:12 leosunmo