OpenDocument.droid
OpenDocument.droid copied to clipboard
opendocument-app
New F-Droid release?
F-Droid is still at 'Version 3.19 (172) (2022-03-04)' while Google Play is at '3.24 (20.08.2023)' or so.
Also what do you think about attaching apks to the release (here at GitHub) so users ob Obtainium can install it that way?
The process to publish on F-Droid was painfully complicated last time I checked... It's not worth it for me, but I'm happy if someone would like to do that for us.
Never heard of Obtainium - sounds interesting! I'll do that from now on. Thanks for the tip!
The process to publish on F-Droid was painfully complicated last time I checked
Agree. That's why there are slow updates and I try to avoid it by using Obtainium for example.
I'll do that from now on.
Greate, Thanks.
The process to publish on F-Droid was painfully complicated last time I checked...
It's as easy as the build procedure of the app... if the app is FOSS and has FOSS dependencies everything is simple...
The current recipe for this app is unfortunately a big web of cleaning commands and of old dependencies versions pins
That aside, trying to update it now... it fails for conan
- versionName: '3.24'
versionCode: 177
commit: f33ded86b3bb0bd4e62c9aead37063a087180043
subdir: app
sudo:
- apt-get update
- apt-get install -y cmake ninja-build python3-pip
- apt-get install -y openjdk-17-jdk-headless
- update-java-alternatives -a
- pip3 install wheel
- pip3 install conan==1.45.0
gradle:
- pro
prebuild:
- sed -i -e '/com.google/d' ../build.gradle
- sed -i -e '/com.google.firebase/d' -e '/firebaseCrashlytics/d' -e '/com.google.android.play/d'
-e '/com.android.billingclient/d' -e '/com.google.gms/d' -e '/pro"/d' -e '/com.google.android.gms/d'
build.gradle
- sed -i -e '/INTERNET/d' -e '/BILLING/d' -e '/^ <meta-data/,+5d' src/main/AndroidManifest.xml
- cd src/main/java/at/tomtasche/reader
- sed -i -e '/com.google.firebase/d' background/FileLoader.java
- sed -i -e '/gms/d' -e '/play.core/d' -e '/firebase/d' ui/activity/*.java
- sed -i -e '/private Uri doFirebaseConvert/,/^ }/d' -e 's/viewerUri = doFirebaseConvert(options)/return/'
-e '/com.google/d' -e '/Firebase/d' -e '/Storage/d' -e '/auth /d' -e '/storage
/d' background/OnlineLoader.java
- sed -i -e '/void initializeProprietaryLibraries/,/^ }/d' -e '/initializeProprietaryLibraries/d'
-e '/void buyAdRemoval/,/^ }/d' -e '/buyAdRemoval/d' -e 's/billingManager.hasPurchased()/true/'
-e 's/billingManager.isEnabled()/false/' -e '/addOnPreDrawListener/,/});/d'
ui/activity/MainActivity.java
- sed -i -e '/getBooleanConfig("show_in_app_rating/,/^ });/d'
-e '/void offerUpload/,/^ }/d' -e '/offerUpload/d' -e '/void requestInAppRating/,/^ }/d'
-e '/requestInAppRating/d' ui/activity/DocumentFragment.java
- sed -i -e 's/configManager.getBooleanConfig(".*")/null/' background/OdfLoader.java
- for class in AdManager AnalyticsManager BillingManager ConfigManager CrashManager
HelpManager; do echo "package at.tomtasche.reader.nonfree; public class ${class}
{}" > nonfree/${class}.java; sed -i -e "/${class}\./Id" background/*.java
ui/*/*.java ui/*.java; done
- conan config set general.revisions_enabled=1
- conan remote add odr https://odr.jfrog.io/artifactory/api/conan/odr-conan
ndk: 25.2.9519653
fails because that odr URL is no longer valid and spits out HTML.
If I don't pin conan version config set is invalid
If I remove both conan lines it fails later for another reason.
The CI workflow I guess is never used, since we're mirroring the same commands that fail.
Perhaps @IzzySoft could add it to their F-Droid repo? Many people already have it enabled and, as far as my limited knowledge goes, there is less bureaucracy than on the official repo, with the main requirement being consent from the developer.
Edit: want to stress the value of this app to the F-Droid FOSS ecosystem. It seems to be the only maintained app that has a decent PDF reader with live text selection (except Librera, which, while powerful, is overwhelmingly complex for novices). Thank you for this great app!
That makes sense, hahaha – you can tell I'm just an enthusiastic user. Didn't intend to make F-Droid look bad, if you got that impression. I really respect the work you and the F-Droid team do.
I would even go so far to say that it's crucial to have a FOSS app like this one on a platform like F-Droid, where typically exactly the target audience for such an app can be found. An audience that could contribute back a lot more than your average Play Store users, IMHO.
Perhaps @IzzySoft could add it to their F-Droid repo?
Exceeds the size limit of my repo by factor 2 unfortunately.
yeah it's all in the name right , Open document reader. Fdroid build is a must . Can't run play store version without Google play services running. Das ist Nicht gut.
No issue here with the apk from https://github.com/opendocument-app/OpenDocument.droid/releases/tag/3.24 when opening odt files.
I have to agree with the previous comments that it is really a pity that this open source app is not available in an up-to-date version on the most important open source app store / repo, which is in fact F-Droid 🙁
It seems that only small details are missing that prevent the app from being compiled and thus updated.
As @licaon-kter mentioned, one problematic line of the at.tomtasche.reader.yml is the following:
conan remote add odr https://odr.jfrog.io/artifactory/api/conan/odr-conan
The URL https://odr.jfrog.io/artifactory/api/conan/odr-conan is no longer valid:
JFrog's Free-Tier subscription has been deactivated.
The process to publish on F-Droid was painfully complicated last time I checked... It's not worth it for me, but I'm happy if someone would like to do that for us.
@TomTasche please reach out to the developers in the corresponding F-Droid issue, as there are actually people trying to do this for you, but they seem to be stuck since December 2023 and need your input: https://gitlab.com/fdroid/fdroiddata/-/issues/2745
Hello. I'm doing some conan work which will eventually solve the artifactory issue. Regards
@ferromint Tom is not really working on this project but I am sure we would be able to review and merge changes when you open a PR about F-Droid.
The problem with artifactory is actually on my side with https://github.com/opendocument-app/OpenDocument.core. JFrog discontinued their free tier and we are not up for paying hundreds of dollars for conan hosting which is not even strictly necessary.
We already built and released new versions of the mobile apps without the hosted version by simply adding the core package recipe to the local repository and the building the mobile apps.
I'm doing some conan work which will eventually solve the artifactory issue
Great to hear that, thank you @ViliusSutkus89 !
Do you think it makes sense to drop a little note (just this one sentence) in the aforementioned F-Droid GitLab issue about your ongoing work, since it has been quite a while since they last heard an "official" statement form you as the developer(s)?
[...] Tom is not really working on this project [...]
Is this only temporary? Did someone take over the lead? Or is the project dying?
[...] but I am sure we would be able to review and merge changes when you open a PR about F-Droid [...]
The problem is that I am neither into F-Droid nor app development, but just looking at the findings in the comments of this and the F-Droid GitLab issue ...
The problem with artifactory is actually on my side with https://github.com/opendocument-app/OpenDocument.core. JFrog discontinued their free tier and we are not up for paying hundreds of dollars for conan hosting which is not even strictly necessary.
That is completely understandable.
We already built and released new versions of the mobile apps without the hosted version by simply adding the core package recipe to the local repository and the building the mobile apps.
Is it possible and will (anyone of) you integrate this core component build recipe into the F-Droid build process of the app so you are not dependent on JFrog's paid hosting of libs and other dependencies? Or is this exactly what @ViliusSutkus89 was mentioning before?
Is this only temporary? Did someone take over the lead? Or is the project dying?
@ViliusSutkus89 is developing and maintaining parts of the project and I am also planning do start doing mobile developments for the app while maintaining the C++ core.
I would also claim that the app works as is and there are no new big features planned at the moment.
The problem is that I am neither into F-Droid nor app development, but just looking at the findings in the comments of this and the F-Droid GitLab issue ...
Neither is any of us developers using F-Droid. Sorry, if people want to use a recent version of the app on F-Droid it is on them to do the work. We are happy to guide them and fix/merge issues on our side but we will not provide or maintain the app on another platform at the moment. Our app is completely open source and in the spirit of OSS people can use our software and bring it to other platforms.
Sorry @licaon-kter I didn't see your issue in-between. Can you open another ticket with the problem description? The issue here is a bit convoluted and does not have a clear dev target.
I will try to get the CI up and running. Currently it is disabled.