alerting-kibana-plugin icon indicating copy to clipboard operation
alerting-kibana-plugin copied to clipboard

Standardize plugin name

Open aetter opened this issue 5 years ago • 2 comments

As noted in https://github.com/opendistro-for-elasticsearch/security-kibana-plugin/issues/19, the alerting plugin uses a dash, whereas everything else uses an underscore:

./bin/elasticsearch-plugin list
opendistro_alerting
opendistro_performance_analyzer
opendistro_security
opendistro_sql

./bin/kibana-plugin list
[email protected]
[email protected]

Expected behavior would be [email protected] (or a dash if we can get all plugins to switch).

aetter avatar Jun 12 '19 19:06 aetter

@aetter list CLI is being handled by Kibana and not by us so can't remove the version. Regarding - and _ IMO, we should be using - thats convention for any JS packages.

mihirsoni avatar Jun 12 '19 20:06 mihirsoni

Hi @mihirsoni, no objection to using - for all plugins, I just want them to all use the same convention.

aetter avatar Jun 12 '19 21:06 aetter