alerting-kibana-plugin icon indicating copy to clipboard operation
alerting-kibana-plugin copied to clipboard

Published 20 hours ago • verified publisher icon opendistro-for-elasticsearch

CI seems broken

Open srilumpa opened this issue 4 years ago • 1 comments

The CI seems broken. Authentication when fetching the kibana repository is not working.

See https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/128/checks?check_run_id=614674392

Screenshot from 2020-04-24 10-33-39

srilumpa avatar Apr 24 '20 08:04 srilumpa

Hi @srilumpa,

Not broken per se, but since it's a private repository it can only be accessed from PRs from a branch in the repo since it needs to use the secret. This is by design from GitHub so an external contributor cannot make a PR that changes the workflow to print the secrets.

We could technically change the events to trigger based off push instead of pull_request so that it instead runs after the fact once a PR is merged. Or both and just acknowledge that it will fail on PRs from forks. Although as shown this would definitely be confusing to anyone else making a PR.

This private repository should be temporary, so hopefully we can live with one of the above fixes for a short while.

dbbaughe avatar Apr 24 '20 16:04 dbbaughe