ods-jenkins-shared-library icon indicating copy to clipboard operation
ods-jenkins-shared-library copied to clipboard

Insufficient user input validation in library

Open serverhorror opened this issue 3 years ago • 1 comments

When using the backslash character (\) in your git username that user input is not properly validated and leads to broken builds

This comes up when users are using their "qualified" Windows login name as their git author info, e.g.: FABRIKAM\\alice ([email protected])

To Reproduce Steps to reproduce the behavior:

  1. Set your git username to domain\\user
  2. commit
  3. push
  4. Jenkins build fails

Expected behavior

The Jenkins build should successfully continue. The username is only a string that should not cause the build to fail

Screenshots If applicable, add screenshots to help explain your problem.

Affected version (please complete the following information):

  • OpenShift: ??
  • OpenDevStack 4.x

serverhorror avatar Apr 21 '22 11:04 serverhorror

@serverhorror We had the issue in Openshift 3.x and OpenDevStack 4.x. I think your description of the issue is complete, I have nothing to add.

KMax avatar Apr 21 '22 12:04 KMax