ods-core icon indicating copy to clipboard operation
ods-core copied to clipboard

cd-user secrets duplicated in central namespace

Open michaelsauter opened this issue 4 years ago • 5 comments

General setup creates a secret named cd-user-token, and the Jenkins installation creates a secret named cd-user-with-password. Both have the same information. We should keep just one.

cd-user-with-password is shipped with the Jenkins template, which might not be ideal. Maybe better to install that separately, also for new projects.

FYI @oalyman

michaelsauter avatar May 05 '20 08:05 michaelsauter

Keep in mind that this secret needs to be a Source secret of a bc to be syncd to jenkins

clemensutschig avatar May 05 '20 09:05 clemensutschig

  • this is the project specific one - (which one needs to modify assuming you use a 'per project user') https://github.com/opendevstack/ods-core/blob/master/jenkins/ocp-config/deploy/jenkins-master.yml#L66-L75 - and it#s created in create-project jenkins job

  • the cd-user-token - should only be in the root / main namespace - and is the 'global' one https://github.com/opendevstack/ods-core/search?q=cd-user-token&unscoped_q=cd-user-token

clemensutschig avatar Jun 19 '20 06:06 clemensutschig

Yes - the duplication is only in the global ods namespace.

michaelsauter avatar Jun 19 '20 06:06 michaelsauter

then we should just rename it to - say global-cd.. - thoughts?

clemensutschig avatar Jun 19 '20 07:06 clemensutschig

I'll move this to v4 as I don't see it that crucial ...

michaelsauter avatar Jun 26 '20 07:06 michaelsauter