ods-core icon indicating copy to clipboard operation
ods-core copied to clipboard

Published 20 hours ago • verified publisher icon opendevstack

Extend code coverage of webhook proxy

Open michaelsauter opened this issue 5 years ago • 0 comments

While there are quite a few tests, we have a few blind spots which should be covered by tests.

From https://github.com/opendevstack/ods-core/pull/231#pullrequestreview-315180615:

  • func (c *ocClient) DeletePipeline(e *Event) error
  • code for not allowed project in /build request are currently not covered. There are also some other error cases without coverage. However the DeletePipeline code has not been changed and is quite old so there is little risk here. For the build request code there is identically looking code for the / request nearby, so this should be fine as well.

FYI @henrjk

michaelsauter avatar Nov 12 '19 11:11 michaelsauter