ods-core icon indicating copy to clipboard operation
ods-core copied to clipboard

Make location of caCert, tokenFile and namespaceFile configurable in Webhook Proxy

Open ungerts opened this issue 5 years ago • 2 comments

Locations of caCert, tokenFile and namespaceFile are currently hard coded in main.go. Making these locations configurable would allow for easier setup of local dev environments.

Proposal is:

namespaceFileDefault  = "/var/run/secrets/kubernetes.io/serviceaccount/namespace"
namespaceFileEnvVar   = "NAMESPACE_FILE"
tokenFileDefault      = "/var/run/secrets/kubernetes.io/serviceaccount/token"
tokenFileEnvVar       = "TOKEN_FILE"
caCertDefault         = "/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"
caCertEnvVar          = "CA_CERT_FILE"

ungerts avatar Jul 11 '19 12:07 ungerts

Also server port is now configurable

ungerts avatar Jul 17 '19 20:07 ungerts

@ungerts This has not been merged yet, right?

michaelsauter avatar Oct 25 '19 13:10 michaelsauter