udata icon indicating copy to clipboard operation
udata copied to clipboard

Update sentry logging

Open maudetes opened this issue 3 years ago • 2 comments

Fix https://github.com/etalab/data.gouv.fr/issues/358 (show sentry event id). Fix https://github.com/etalab/data.gouv.fr/issues/231 (update from raven to sentry).

SENTRY_PUBLIC_DSN was required to set meta tags accordingly (see https://github.com/etalab/data.gouv.fr/issues/352#issuecomment-876588788) and had been removed in #2620. Sentry event id should now be displayed on error.

Left to discuss:

  • Couldn't test that sentry event id showed on 400 or 500 due to DON'T PANIC werkzeug traceback.
  • Not sure how to deal with this legacy eventListener here. Couldn't find a corresponding logic in the new sdk.
  • Not sure what logger param was used for here and if we can find a corresponding configuration if still relevant.

maudetes avatar Jul 16 '21 15:07 maudetes

Cherry-picked sentry event logging in https://github.com/opendatateam/udata/pull/2634. Not sure we should update the sentry sdk as I can't find trace of support for vue 1 in the documentation.

maudetes avatar Jul 27 '21 15:07 maudetes

For some errors (not all of them), Sentry exception trace is missing with updated sdk.

image VS image

Couldn't find a solution to capture the stack trace correctly.

maudetes avatar Aug 11 '21 10:08 maudetes

@maudetes Is this still something we want to do? :-)

ThibaudDauce avatar Apr 04 '24 09:04 ThibaudDauce

I think it hasn't been prioritized since, thus we can probably close and reopen if needed.

maudetes avatar Apr 05 '24 08:04 maudetes