cyrillic-transliteration icon indicating copy to clipboard operation
cyrillic-transliteration copied to clipboard

Ukrainian support: doesn't process Ї (yi) letter

Open daubmannus opened this issue 5 months ago • 3 comments

installed cyrtranslit-1.1.1

echo 'Її' | cyrtranslit -l UA output: Ïï (i.e. not changed)

daubmannus avatar Jan 26 '24 08:01 daubmannus

installed cyrtranslit-1.1.1

echo 'Її' | cyrtranslit -l UA output: Ïï (i.e. not changed)

What output woul'd you expect? Is "Ji" ok?

petalser avatar Apr 14 '24 21:04 petalser

I'd expect anything in ASCII, not cyrillic. I think 'Ji/ji' is possible option, better than keep it cyrillic.

But I have to admit also that I couldn't figure out what is the source of transliteration system here. I's definitely not official one (https://czo.gov.ua/en/translit)

daubmannus avatar Apr 17 '24 11:04 daubmannus

Hi Team! Thank you for your input. Here's a pull request with the fix: https://github.com/opendatakosovo/cyrillic-transliteration/pull/43

@daubmannus: try it out and if it works I'll merged it in and prepare a v1.1.2 release.

I made sure it works with different casing variations:

>>> import cyrtranslit
>>> cyrtranslit.to_cyrillic("Ji", "ua")
'Ї'
>>> cyrtranslit.to_cyrillic("JI", "ua")
'Ї'
>>> cyrtranslit.to_cyrillic("ji", "ua")
'ї'
>>> cyrtranslit.to_cyrillic("jI", "ua")
'ї'

georgeslabreche avatar Apr 20 '24 22:04 georgeslabreche