odd-platform icon indicating copy to clipboard operation
odd-platform copied to clipboard

Name of the the button "Add custom name" and label in modal window are not the same on Dataset page

Open nstkvl opened this issue 3 years ago • 2 comments
trafficstars

Set up https://platform.dev.odd.provectus.io/dataentities/24027406/overview

Steps to Reproduce

  1. Login with valid data
  2. Go to the Catalog page
  3. Open Datasets
  4. Open some dataset from the list
  5. Tap on "Add custom name" button
  6. Pay attention to the name of the label on the modal window that appears

Expected result The name of the button and label should be the same. Need some discussion about which exact name should be

Actual result The name of the button and label are different.

Attachment https://recordit.co/yuwg1biVFQ

nstkvl avatar Jul 20 '22 11:07 nstkvl

@Anna-EG

nstkvl avatar Jul 20 '22 11:07 nstkvl

@DementevNikita @nstkvl When we enter a new name, it replaces the original one. So "add" the name is not exactly what we do here. I would like to suggest "Edit name" for the button instead of "Add custom name" and "Edit datasource name" as a title for the modal window.

Anna-EG avatar Jul 21 '22 12:07 Anna-EG

@DementevNikita @Anna-EG

When user first time want to change name of the entity - he exactly add name (external) that replaces original (internal) name. So, in my opinion there are two states of this button/modal:

  1. Firstly - "Add custom name" / "Add custom name"
  2. Edit - "Edit custom name" / "Edit custom name"

Modal window input label - "Custom name" Modal window input placeholder - "Enter custom name"

Also, user could change name of the entity of all types, not only datasources.

Leshe4ka avatar Aug 25 '22 16:08 Leshe4ka