eo-datasets icon indicating copy to clipboard operation
eo-datasets copied to clipboard

add platform for derived as folder part

Open pindge opened this issue 1 year ago • 2 comments

Fixes: #298

addes platform abbrev to end of the dataset folder path if its c3 derivative product.

pindge avatar Mar 28 '23 03:03 pindge

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (17f80b6) 84.77% compared to head (9efe2c3) 84.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    84.77%   84.78%   +0.01%     
===========================================
  Files           26       26              
  Lines         4408     4411       +3     
===========================================
+ Hits          3737     3740       +3     
  Misses         671      671              
Impacted Files Coverage Δ
eodatasets3/names.py 95.26% <100.00%> (+0.04%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 28 '23 05:03 codecov[bot]

As is discussed on Teams, the approval for this as a change is going through other channels, as eo-datasets is just following the upstream "naming conventions" documents that were made.

If it is approved, though, we should probably make this a different naming_conventions="blah" variant, rather than modfiying the existing one and breaking backwards compatibility. Products can then choose the move to the new one rather than have datasets start appearing in unexpected places.

jeremyh avatar Mar 29 '23 01:03 jeremyh