datacube-explorer
datacube-explorer copied to clipboard
Parse NCI filepaths to THREDDS location
As per #520
📚 Documentation preview 📚: https://datacube-explorer--523.org.readthedocs.build/en/523/
Codecov Report
Attention: Patch coverage is 42.85714%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 86.24%. Comparing base (
aa0d9f3
) to head (358fe01
). Report is 4 commits behind head on develop.
:exclamation: Current head 358fe01 differs from pull request most recent head d6ffbd7. Consider uploading reports for the commit d6ffbd7 to get more accurate results
Files | Patch % | Lines |
---|---|---|
cubedash/_utils.py | 42.85% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #523 +/- ##
===========================================
- Coverage 86.29% 86.24% -0.05%
===========================================
Files 26 26
Lines 3451 3461 +10
===========================================
+ Hits 2978 2985 +7
- Misses 473 476 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
an opt-in/configurable option
Yes, I expect this would be good to have configurable by a deployment admin. Sharing some ideas, if helpful.
If URL converting regexs or functions were imported from settings.env.py
we'd need to consider the security implications and do some careful vetting. I'm not sure of the effort or appetite to look at it from that perspective. A transparent in-code solution would be easier.
As a deployment patch perhaps? Perhaps settings.env.py
could reference an as_external_url
function that can be imported by explorer, else the "s3" default is used. The custom as_external_url
function would need to be uploaded to the host running explorer. This may require an update to the explorer chart too.
Could we please update this to latest develop to avoid potential merge with rebase
issues, especially if global settings are being changed. This will affect the main file where the timezone setting was recently added.