This is going to log every time they run `init`, even if they already have applied this update.

[whatnick]

This is going to log every time they run init, even if they already have applied this update.

By convention, I usually wrapped them in a check previously:

if not pg_column_exists(engine, schema_qualified('dataset'), 'updated'):
    _LOG.info("Adding Update Triggers")
    with engine.connect() as c:
        c.execute('begin')
        install_timestamp_trigger(c)
        .... etc

(of course, no need to check other columns exist as they're all applied together in one transaction.)

The actual SQL looks idempotent so this is all an extremely minor gripe.

Originally posted by @jeremyh in https://github.com/opendatacube/datacube-core/pull/951

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[omad]

This has been resolved with the new PostGIS database driver, and is a wontfix for the old PostgreSQL driver.