devices.sensor.community icon indicating copy to clipboard operation
devices.sensor.community copied to clipboard

Broken requirements.txt and Pipfile

Open Informatic opened this issue 5 years ago • 0 comments

Seems like Pipfile is missing some dependencies defined in requirements.txt. (ex. Flask-Security - a direct project dependency, while also containing some second-level dependencies like asn1crypto) Additionally, as requirements.txt now does >= version match, newest version of psycopg2 fails to install in Docker environment due to missing postgresql headers (psycopg2 used to default to binary build, now this is split into psycopg2-binary package, it seems) - replacing psycopg2 with psycopg2-binary in requirements.txt solves this partially in that case.

Generally speaking, we should always have some locked versions, that could then be upgraded. I haven't used Pipfile so can't really say anything about it, if Pipfile.lock really locks proper version, then we can fully migrate to Pipfile. In that case we'd have to re-add missing dependencies from requirements.txt into Pipfile and modify Dockerfile to only use Pipfile/pipenv.

@ohheyitsdave can you elaborate on that?

Informatic avatar May 05 '19 19:05 Informatic