opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

Added QualityMAE with tests

Open JulienFleuret opened this issue 11 months ago • 6 comments

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x] I agree to contribute to the project under Apache 2 License.
  • [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [x ] The PR is proposed to the proper branch
  • [ ] There is a reference to the original bug report and related work
  • [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
  • [x] The feature is well documented and sample code can be built with the project CMake

Co-authored-by: Julien Fleuret [email protected] Co-authored-by: Esmaiel Hoja Najafabadi [email protected] Co-authored-by: Anshul Joshi [email protected]

JulienFleuret avatar Mar 08 '24 19:03 JulienFleuret

@opencv-alalek Sorry to bother you. The project seems not to compile due to something in the ARUCO tests, which I did not touched. What is the should I do to makes things moving forward?

JulienFleuret avatar Mar 11 '24 15:03 JulienFleuret

Please revert your aruco changes - they are not related to this PR (problem should be fixed separately after wrong merge of #3401)

opencv-alalek avatar Mar 15 '24 03:03 opencv-alalek

@opencv-alalek Sorry to bother you with that. I would like to add two contributors to my work, how can I do that?

JulienFleuret avatar Mar 18 '24 12:03 JulienFleuret

You can mention them in the commit message, see https://stackoverflow.com/questions/7442112/how-to-attribute-a-single-commit-to-multiple-developers Also in the PR description.

mshabunin avatar Mar 19 '24 20:03 mshabunin

It's been more than a week without notification from you. Is there anything I should do or anything I missed?

JulienFleuret avatar Apr 07 '24 13:04 JulienFleuret

May I have a feedback about what remains to do, to be allowed to do the pull-request?

JulienFleuret avatar Apr 21 '24 17:04 JulienFleuret