curve
curve copied to clipboard
print error code with more meaningful name
curve has three types of error codes
- protobuf enum type
- C++ enum type, e.g., https://github.com/opencurve/curve/blob/14938624132ba0e88396f6b46b0c2f715e40b3c4/include/client/libcurve_define.h#L30
- raw error value, e.g., https://github.com/opencurve/curve/blob/14938624132ba0e88396f6b46b0c2f715e40b3c4/src/mds/common/mds_define.h#L76
now, in some error path, we only print the raw value of them instead of more meaningful name which result in bad experience.
Hi, I am a newbie in c++ and interested in this issue to try it out. I would like to know if there is some additional information that can help me understand this issue and this project better.
can i be assigned this issue
can i be assigned this issue
Thank you very much for your interest in this issue, this issue will be assigned to you.
@beertocode Are you working on this task? any help?
@beertocode Is this still going on?
Please assign me.
@beertocode Due to no feedback for a long time, the issue is reassigned.
Please assign me.
Welcome!
Hello, I encountered an error when submitting pr, but I don't seem to understand what happened. The error message is as follows:
GitHub pull request #2286 of commit d817215abc36b148ac880d39d0601314707cde2f, no merge conflicts. Running as SYSTEM Setting status of d817215abc36b148ac880d39d0601314707cde2f to PENDING with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build started for merge commit.' [EnvInject] - Loading node environment variables. Building remotely on failover-slave3 (curve-failover-build3) in workspace /home/nbs/jenkins/workspace/waiting_in_line [waiting_in_line] $ /bin/bash /tmp/jenkins4459845953071838805.sh No build required,fail ERROR: [GitHub Commit Status Setter] - Cannot retrieve Git metadata for the build, setting build result to FAILURE Build step 'Set build status on GitHub commit [deprecated]' changed build result to FAILURE Setting status of d817215abc36b148ac880d39d0601314707cde2f to FAILURE with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build finished. ' Finished: FAILURE
Hello, I encountered an error when submitting pr, but I don't seem to understand what happened. The error message is as follows:
GitHub pull request #2286 of commit d817215, no merge conflicts. Running as SYSTEM Setting status of d817215 to PENDING with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build started for merge commit.' [EnvInject] - Loading node environment variables. Building remotely on failover-slave3 (curve-failover-build3) in workspace /home/nbs/jenkins/workspace/waiting_in_line [waiting_in_line] $ /bin/bash /tmp/jenkins4459845953071838805.sh No build required,fail ERROR: [GitHub Commit Status Setter] - Cannot retrieve Git metadata for the build, setting build result to FAILURE Build step 'Set build status on GitHub commit [deprecated]' changed build result to FAILURE Setting status of d817215 to FAILURE with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build finished. ' Finished: FAILURE
hi, waiting_in_line
is used to prevent PR been merged before passing CI, and you should comment cicheck
to manually trigger it. And I have done this, you can check the results.
Oh, I see, thank you so much.
@gueFDF you don't have to close and recreate a new pull request if you change something, just add and commit you changes, then git push
, the pull request will automatically update
@gueFDF you don't have to close and recreate a new pull request if you change something, just add and commit you changes, then
git push
, the pull request will automatically update
I see, thank you.
@gueFDF Are you still going on?
how should i to find the error path with raw value, i try to search the raw value, but can't find anymore
how should i to find the error path with raw value, i try to search the raw value, but can't find anymore
Mostly, these error codes/types are usually used as a return value rather than the original value. So, you can try to find places to use them.
can i be assigned this issue?
how should i to find the error path with raw value, i try to search the raw value, but can't find anymore
Mostly, these error codes/types are usually used as a return value rather than the original value. So, you can try to find places to use them.
Okay, I know what to do. Thank you, okay
Is this task over? I see that the event registration there has stopped applying, but see that this issue has not been closed
Hi, @XR-stb since we didn't receive a response for a long time, we put this issue in developer activity and it has been assigned to NopeDl. It's our mistake for not telling you earlier, you can still find issues of interest and participate in this event from here, https://github.com/opencurve/curve/issues/2603.
Hi, @XR-stb since we didn't receive a response for a long time, we put this issue in developer activity and it has been assigned to NopeDl. It's our mistake for not telling you earlier, you can still find issues of interest and participate in this event from here, #2603.
Okay, that's okay, I'll see if there's other thing I can do to help