curve
curve copied to clipboard
opencurve
[compile] update brpc to release1.3 version
Signed-off-by: fan [email protected]
What problem does this PR solve?
Issue Number: https://github.com/opencurve/curve/issues/2034#event-7780133596
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?): some unix_socket patch test has some errors but can compile pass.
Check List
- [ ] Relevant documentation/comments is changed or added
- [ ] I acknowledge that all my contributions will be made under the project's license
The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in echo_c++_unix_socket_server and echo_c++_unix_socket_client client.
It seems I do something wrong with patch.
Can the old patch author help me to fix it? I don't know more about bRPC.
The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in
echo_c++_unix_socket_serverandecho_c++_unix_socket_clientclient. It seems I do something wrong with patch. Can the old patch author help me to fix it? I don't know more about bRPC.
Can you paste the error output?
The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in
echo_c++_unix_socket_serverandecho_c++_unix_socket_clientclient. It seems I do something wrong with patch. Can the old patch author help me to fix it? I don't know more about bRPC.Can you paste the error output?
Just the echo_unix_socket_client can not connect echo_unix_socket_server.
I conjecture it is my new patch error.
@ilixiaocui, @wu-hanqing has help me to fix the test error. Now the release-1.3 version bRPC has been support unix_socket. Should we use upstream unix_socket?
Not only the domain_unixsocket_test is fail, and many tests.
More test failures can use this patch and run brpc_tests.
Not only the domain_unixsocket_test is fail, and many tests.
More test failures can use this patch and run brpc_tests.
How about submit the patch to bRPC?
Not only the domain_unixsocket_test is fail, and many tests. More test failures can use this patch and run brpc_tests.
How about submit the patch to bRPC?
I think it is not a good idea. bRPC will not accept our customized patch.