opencost icon indicating copy to clipboard operation
opencost copied to clipboard

Published 20 hours ago • verified publisher icon opencost

use per-provider localstorage charges

Open AjayTripathy opened this issue 3 years ago • 4 comments

What does this PR change?

Azure, AWS, GCP, all use different kinds of system mounts and chargeback models to place disks and the node's root disk into the VM. This gives us the freedom to configure chargeback in a per-provider way.

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Improved accuracy for non-PV storage costs

How was this PR tested?

Deployed on Azure and made sure only PVs were counted

AjayTripathy avatar Sep 07 '21 05:09 AjayTripathy

Do we still need to make this change? Happy to re-review once merge conflicts are fixed!

michaelmdresser avatar Nov 15 '21 17:11 michaelmdresser

Checking in: @AjayTripathy are we still interested in including this code?

michaelmdresser avatar May 03 '22 21:05 michaelmdresser

@AjayTripathy friendly ping...

dwbrown2 avatar May 10 '22 16:05 dwbrown2

This code is still relevant. We should keep it and get it reviewed to improve our model for local storage pricing.

AjayTripathy avatar May 10 '22 19:05 AjayTripathy

@AjayTripathy are we still interested in this PR?

michaelmdresser avatar Jun 23 '23 19:06 michaelmdresser

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

github-actions[bot] avatar Nov 30 '23 01:11 github-actions[bot]

Closing as stale. Please reopen and rebase your PR if you feel this was in error.

mattray avatar Nov 30 '23 07:11 mattray