opencost
opencost copied to clipboard
Remove Node Price Outlier Detection
What does this PR change?
- Removes the check to see if node prices change more than 30x the running average
Does this PR relate to any other PRs?
- No?
How will this PR impact users?
- Disables outlier detection of the node price
Does this PR address any GitHub or Zendesk issues?
- #1098
- #1215 (Potentially)
How was this PR tested?
- https://hub.docker.com/layers/196916550/srpomeroy/cost-model/disable-outlier/images/sha256-9185a79a3fc7097a05f5db81031ef7d70c35d0c571219b0e2dbb8dd72d16f844?context=repo
Does this PR require changes to documentation?
- No
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next Kubecost release? If not, why not?
- Unsure
@AjayTripathy I only removed the logic to test for outliers. I'm not sure if we still need the node price average logic.
@srpomeroy Anything blocking getting this PR opened and merged?
@Adam-Stack-PM I will redirect that question to @AjayTripathy as he is the one that asked me to open the PR in the first place.
This pull request was closed because it has been inactive for 65 days with no activity.