opencost icon indicating copy to clipboard operation
opencost copied to clipboard

update labels

Open tomkennes opened this issue 3 years ago • 2 comments

What does this PR change?

  • Read labels config from file

Does this PR rely on any other PRs?

  • not sure to be honest, I haven't seen it yet

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Should be no direct impact, other than that you can provide kubecost with meaningful values in the settings section. In the future, you should be able to pass these on to the metrics as labels. That might be very beneficial when dealing a large number of clusters on an enterprise level.

Links to Issues or ZD tickets this PR addresses or fixes

  • Not that I now off

How was this PR tested?

  • I ran the build as describe in the Readme. Works. I was not able to test the actual reading of the file. Maybe you can help out?

Have you made an update to documentation?

No, not yet. But if this PR get approved I promise to do it later.

tomkennes avatar Dec 16 '21 09:12 tomkennes

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Google API Key f161b6fe9f1ce7b6b3f71e34c62d8cb260a6cd2c kubernetes/deployment.yaml 19:02 January 19th, 2022 View secret
Google API Key b44c1afb5ff949d210302ab168a62bc43113a070 kubernetes/deployment.yaml 19:02 January 19th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

gitguardian[bot] avatar Dec 16 '21 09:12 gitguardian[bot]

@AjayTripathy or @mbolt35, are there any other needed changes for this PR?

keithhand avatar Apr 01 '22 19:04 keithhand

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

github-actions[bot] avatar Nov 30 '23 01:11 github-actions[bot]

Closing as stale. Please reopen and rebase your PR if you feel this was in error.

mattray avatar Nov 30 '23 07:11 mattray