umoci icon indicating copy to clipboard operation
umoci copied to clipboard

Ignore error when xattr data is not available

Open rchincha opened this issue 2 years ago • 5 comments

When the underlying filesystem is overlayfs, it is possible that xattrs are present but without the data. So check for this case specifically and ignore it.

Signed-off-by: Ramkumar Chinchani [email protected]

rchincha avatar Jan 30 '23 20:01 rchincha

Is this CI failure related to this PR?

Run # TODO: Move this to 'make fetch-deps'.
  # TODO: Move this to 'make fetch-deps'.
  GO111MODULE=off go get -u github.com/cpuguy83/go-md2man
  GO111MODULE=off go get -u golang.org/x/lint/golint
  GO111MODULE=off go get -u github.com/securego/gosec/cmd/gosec
  GO111MODULE=off go get -u github.com/client9/misspell/cmd/misspell
  shell: /usr/bin/bash -e {0}
# github.com/securego/gosec/rules
Error: ../../../go/src/github.com/securego/gosec/rules/readfile.go:29:17: undefined: any
Error: ../../../go/src/github.com/securego/gosec/rules/readfile.go:63:11: assignment mismatch: 2 variables but 1 value
Error: ../../../go/src/github.com/securego/gosec/rules/readfile.go:135:19: undefined: any
Error: Process completed with exit code 2.

rchincha avatar Jan 30 '23 21:01 rchincha

No, it's because we haven't bumped the Go version for linting recently. I'll fix it now.

cyphar avatar Apr 17 '23 13:04 cyphar

@rchincha Can you rebase this? CI has been fixed.

cyphar avatar Apr 29 '23 12:04 cyphar

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.40%. Comparing base (7b9470b) to head (89a7ea1). Report is 39 commits behind head on main.

:exclamation: Current head 89a7ea1 differs from pull request most recent head 4d17e64. Consider uploading reports for the commit 4d17e64 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   73.45%   73.40%   -0.05%     
==========================================
  Files          60       57       -3     
  Lines        4886     4885       -1     
==========================================
- Hits         3589     3586       -3     
  Misses        937      937              
- Partials      360      362       +2     
Files Coverage Δ
pkg/system/copy.go 48.27% <100.00%> (+10.34%) :arrow_up:
mutate/compress.go 44.92% <50.00%> (+1.59%) :arrow_up:

... and 4 files with indirect coverage changes

codecov-commenter avatar Oct 25 '23 18:10 codecov-commenter

Can you rebase with only the commits for this branch and drop all the merge noise?

tych0 avatar Mar 25 '24 21:03 tych0