umoci icon indicating copy to clipboard operation
umoci copied to clipboard
verified publisher icon opencontainers

0.4.4: missing vendored `rootlesscontainers.proto`

Open onlyjob opened this issue 6 years ago • 4 comments

vendor/github.com/rootless-containers/proto/go-proto/rootlesscontainers.proto is missing. This file is a source for pre-built/generated vendor/github.com/rootless-containers/proto/go-proto/rootlesscontainers.pb.go and now the latter is a source-less file which can not be re-built.

For open source compliance (and best practice) please make sure that umoci source tree is comprehensive and that all source files required to (re-)build all generated files are included.

Thanks.

onlyjob avatar Feb 02 '19 02:02 onlyjob

Thanks -- it looks like this was a go mod vendor regression -- the change came from #279 (where a fix was made related to a different go mod regression). Sigh loudly. I'll figure out WTF is going on.

(Though, given that Debian doesn't use vendor/ this in theory shouldn't cause problems for you folks -- right?)

cyphar avatar Feb 02 '19 08:02 cyphar

Well, we are not entirely vendor-less, especially in applications exclusively consuming some micro-libraries. :) Currently rootless-containers is privately vendored within "umoci" Debian package and I've stumbled upon this issue when I was packaging new release... For now I've introduced .proto file with the patch.

Thank you.

onlyjob avatar Feb 02 '19 12:02 onlyjob