Testing process.terminal?

[wking]

#66 currently checks the terminal box with a reference to this code setting terminal to false in the default template. Grepping through the current master doesn't turn up anything that looks like tests though:

$ git describe --always
0b5e2eb
$ git grep -i terminal | grep -v Godeps
generate.go:            spec.Process.Terminal = context.Bool("tty")
generate.go:                    Terminal: false,

I think the current spec wording is untestably vague, and there's a recent runtime-spec issue that agrees (opencontainers/runtime-spec#494). One possible outcome is dropping the property from the spec. But in the face of all this uncertainty, I expect we want to:

• Uncheck the terminal box in #66 (ping @liangchenye).
• Avoid testing the property until we have testable language for it in the spec, and understand if/why we are going to keep it in the spec.

[liangchenye]

@wking sorry for being late, #66 was updated.

[wking]

Cross linking upstream improvements in this area, there is work on clarifying the container side of terminal in opencontainers/runtime-spec#518, and after that lands there are plans to address the host side in opencontainers/runtime-spec#513. The API side is tied up with what runC can support, and that is being discussed in opencontainers/runC#814.