runc icon indicating copy to clipboard operation
runc copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

[RFC] Which runc version should we set in the /VERSION file on the main branch?

Open rata opened this issue 8 months ago • 5 comments

Now we have:

  • main: VERSION 1.3.0-rc.1+dev
  • release-1.3: VERSION 1.3.0-rc.1 (even after the tag)

Shall release-1.3 have 1.3.0-rc.1+dev? In which case main might be 1.4.<something>?

What do others think?

rata avatar Mar 14 '25 20:03 rata

The version should be dynamically set from ReadBuildInfo()

https://github.com/containerd/nerdctl/blob/v2.0.3/pkg/version/version.go

AkihiroSuda avatar Mar 17 '25 17:03 AkihiroSuda

@AkihiroSuda that is the go version, right? No, sorry, I meant the runc version we put in the VERSION file

rata avatar Mar 18 '25 10:03 rata

that is the go version

No, the version of the runc module

AkihiroSuda avatar Mar 18 '25 10:03 AkihiroSuda

@AkihiroSuda not sure I follow. When someone runs runc -v in a runc compiled from main now, what should the runc version be?

rata avatar Mar 19 '25 10:03 rata

@AkihiroSuda not sure I follow. When someone runs runc -v in a runc compiled from main now, what should the runc version be?

Should be the value of the vcs.revision (i.e., the git commit hash)

AkihiroSuda avatar Mar 19 '25 11:03 AkihiroSuda