runc make trimpath optional

Fixes #3906

Makes -trimpath optional by calling it as

make runc TRIMPATH=

The default mode is unchanged.

Comments in the Makefile make it clear that this may still be required for reproducible builds.

cc @cyphar

Jun 20 '23 13:06 deitch

codespell is complaining about a non-error, that isn't even part of this PR 🤷‍♂️

Jun 20 '23 14:06 deitch

codespell is complaining about a non-error, that isn't even part of this PR man_shrugging

This is being fixed in https://github.com/opencontainers/runc/pull/3907 which is waiting for another LGTM. Please ignore for now.

Jun 21 '23 15:06 kolyshkin

Cool. I'll ignore. Waiting to see if @cyphar wants me to rename it as suggested in his comment, or just leave it like this.

Jun 21 '23 15:06 deitch

@cyphar and @kolyshkin what can I do to move this ahead?

Jun 27 '23 19:06 deitch

Rebased on main now that #3907 is in. What else can I do to move this ahead?

Jul 02 '23 08:07 deitch

Also, whatever you did in #3907 works, as that check no longer is failing.

Jul 02 '23 08:07 deitch

Been a few weeks; can we get a review and a potential merge, please?

Jul 17 '23 11:07 deitch

I rebased to latest main

Jul 17 '23 11:07 deitch