runc icon indicating copy to clipboard operation
runc copied to clipboard

Implement Intel RDT matching line check for pre-existing ClosId schemata.

Open ipuustin opened this issue 1 year ago • 8 comments

OCI Linux config spec specifies that if ClosId is set, the assigned values must match to the current values (if the closid resctrl sub-directory was pre-existing). Previously there was a TODO indicating that this functionality was missing.

ipuustin avatar Apr 19 '23 11:04 ipuustin

@marquiz

ipuustin avatar Apr 19 '23 14:04 ipuustin

ping @kolyshkin @xiaochenshen

marquiz avatar Apr 25 '23 08:04 marquiz

@ipuustin @marquiz Do we need to move the lines parsing and schemata checking helper functions and related code out from intelrdt.go to a separate file? And then just call checkExistingSchemataI() in Set() in intelrdt.go. It may make file intelrdt.go simpler.

Thanks for the review! I moved the schemata line parsing and comparsion to a separate file now.

ipuustin avatar Apr 26 '23 10:04 ipuustin

Rebased.

ipuustin avatar May 02 '23 06:05 ipuustin

Rebased.

ipuustin avatar May 09 '23 11:05 ipuustin

Thanks @kolyshkin for the review! All the review comments should be addressed now. I think it makes sense to work on this PR first, because the other PR (with the proposed spec changes) will need rework when we modify the spec according to your proposal there.

ipuustin avatar Jun 01 '23 17:06 ipuustin

Rebased. @kolyshkin WDYT?

ipuustin avatar Jun 13 '23 07:06 ipuustin

Rebased. Ping @kolyshkin !

ipuustin avatar Jul 27 '23 08:07 ipuustin