runc
runc copied to clipboard
Implement Intel RDT matching line check for pre-existing ClosId schemata.
OCI Linux config spec specifies that if ClosId is set, the assigned values must match to the current values (if the closid resctrl sub-directory was pre-existing). Previously there was a TODO indicating that this functionality was missing.
@marquiz
ping @kolyshkin @xiaochenshen
@ipuustin @marquiz Do we need to move the lines parsing and schemata checking helper functions and related code out from intelrdt.go to a separate file? And then just call checkExistingSchemataI() in Set() in intelrdt.go. It may make file intelrdt.go simpler.
Thanks for the review! I moved the schemata line parsing and comparsion to a separate file now.
Rebased.
Rebased.
Thanks @kolyshkin for the review! All the review comments should be addressed now. I think it makes sense to work on this PR first, because the other PR (with the proposed spec changes) will need rework when we modify the spec according to your proposal there.
Rebased. @kolyshkin WDYT?
Rebased. Ping @kolyshkin !