runc icon indicating copy to clipboard operation
runc copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

Implement to set a domainname

Open utam0k opened this issue 3 years ago • 5 comments

https://github.com/opencontainers/runtime-spec/pull/1156

utam0k avatar Sep 11 '22 00:09 utam0k

Can we have an integration test too?

AkihiroSuda avatar Sep 11 '22 06:09 AkihiroSuda

@AkihiroSuda @kolyshkin Thanks for your great review 🙇 I have updated it. Please retake a look at it.

utam0k avatar Sep 12 '22 07:09 utam0k

  1. Looks like you need to squash the second commit into the first one.
  2. Not sure why you require root in your test case; I think that UTS namespace works in rootless containers.

kolyshkin avatar Sep 15 '22 18:09 kolyshkin

@kolyshkin Sorry for the late. May I ask you to review again?

utam0k avatar Sep 23 '22 08:09 utam0k

hmm... It seems that the integration test on cent-os7 failed.

# stat: cannot read file system information for ‘/sys/fs/cgroup/unified’: No such file or directory
# /home/runc/tests/integration/helpers.bash: line 76: jq: command not found
# /home/runc/tests/integration/helpers.bash: line 76: jq: command not found

utam0k avatar Sep 25 '22 06:09 utam0k

hmm... It seems that the integration test on cent-os7 failed.

This is fixed by https://github.com/opencontainers/runc/pull/3614, please rebase.

Also PTAL https://github.com/containers/crun/pull/1017

kolyshkin avatar Oct 03 '22 17:10 kolyshkin

Also PTAL https://github.com/containers/crun/pull/1017

Do I have to address it in this PR?

utam0k avatar Oct 04 '22 11:10 utam0k

Do I have to address it in this PR?

Ideally, yes. At the very least please open an issue.

kolyshkin avatar Oct 07 '22 01:10 kolyshkin

Do I have to address it in this PR?

Ideally, yes. At the very least please open an issue.

I think this PR has been going on too long, so I'll respond with another PR. I will set up an issue today night.

utam0k avatar Oct 07 '22 02:10 utam0k

@kolyshkin Sorry for the poor setup on my first contribution. Thanks for the kind review.

utam0k avatar Oct 07 '22 02:10 utam0k

LGTM, but could you squash commits?

AkihiroSuda avatar Dec 27 '22 06:12 AkihiroSuda

@kolyshkin LGTY?

AkihiroSuda avatar Jan 31 '23 00:01 AkihiroSuda

Please squash commits

AkihiroSuda avatar Feb 01 '23 01:02 AkihiroSuda

Please squash commits

@AkihiroSuda ✅

utam0k avatar Feb 01 '23 06:02 utam0k

Sorry, seems to need rebase to pass the CI

AkihiroSuda avatar Feb 13 '23 00:02 AkihiroSuda

Sorry, seems to need rebase to pass the CI

@AkihiroSuda Thanks for letting me know. How's this?

utam0k avatar Feb 14 '23 11:02 utam0k

@kolyshkin LGTY?

AkihiroSuda avatar Feb 15 '23 02:02 AkihiroSuda

@kolyshkin LGTY?

AkihiroSuda avatar Apr 18 '23 05:04 AkihiroSuda

@kolyshkin / @AkihiroSuda may I ask when will this change be added to one of the runc releases? If I'm right, I don't think any of the current released runc has this change added / supported.

YJDoc2 avatar Nov 06 '23 10:11 YJDoc2