runc
runc copied to clipboard
Add go 1.19, require go 1.18, drop go 1.17
This makes go 1.18 a minimally required version, removing go 1.17 from and adding go 1.19 to CI.
Also:
- [x] remove old-style
+build
tags - [x] fix the docstrings to be compatible with go 1.19 (see https://tip.golang.org/doc/comment)
- [x] wait for golangci-lint release that fixes https://github.com/golangci/golangci-lint/issues/2922
- [x] remove
test (1.17.x)
from the required set of tests - [ ] add
test (1.19.x)
to required list of tests (once this is merged)
OK, it seems to be working fine, except for golangci-lint (filed https://github.com/golangci/golangci-lint/issues/2922)
1.19 is GA now
Alas we have to wait for a new golangci-lint release that has https://github.com/golangci/golangci-lint/issues/2922 fixed. The fix is already merged but no release has been made yet (I guess it will be v1.48).
Since I've already marked 1.19.x CI tests as required, can we please merge this? @opencontainers/runc-maintainers PTAL
@AkihiroSuda PTAL 🙏🏻
@kolyshkin are you updating the repo settings? ("add test (1.19.x) to required list of tests (once this is merged)")