runc icon indicating copy to clipboard operation
runc copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

Minor cleanups in libcontainer and loadFactory

Open thaJeztah opened this issue 3 years ago • 2 comments

libct.IntelRdtFs(): simplify

  • remove unneeded wrapping func, as intelrdt.NewManager already has the correct signature.
  • reverse the if/else to be clearer that either "IsCATEnabled()" and/or "IsMBAEnabled()" need to be enabled (and to allow skipping one of those checks in the condition).

loadFactory(): remove unneeded intermediate variable

thaJeztah avatar Jan 19 '22 10:01 thaJeztah

Can we please have this one after https://github.com/opencontainers/runc/pull/3316? That one is a major refactoring and is removing some stuff which is modified here.

kolyshkin avatar Jan 20 '22 18:01 kolyshkin

Yes! Fine to do it after, if anything is left then (I didn't see those changes until after I created this PR ☺️)

thaJeztah avatar Jan 20 '22 20:01 thaJeztah

It looks like there's nothing left to fix after #3354 (commit dbd990d5559733bd0f33e2bc23facd2e866cac53)

kolyshkin avatar Aug 16 '22 16:08 kolyshkin