project-template icon indicating copy to clipboard operation
project-template copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

.pullapprove.yml: Count rejections against

Open wking opened this issue 8 years ago • 4 comments
trafficstars

Distinguish between “I haven't looked at this” (no need to say anything) and “I have looked at this and don't like it” (say something matching the reject_regex).

Spun off from #29, since it's an independent change and there was some question about whether we want it. I think we do want it, but either way, there's no need to hold up #29 before we decide on this point. #29 should be reviewed first, because this commit sits on top of it.

Docs here.

wking avatar Mar 17 '17 16:03 wking

Rebased onto master with fa72f6b now that #29 has landed.

wking avatar Mar 17 '17 17:03 wking

The PullApprove failure is because we don't have a selinux-maintainers group on this repo.

wking avatar Mar 20 '17 20:03 wking

@wking it's been renamed: https://github.com/orgs/opencontainers/teams/selinux-maintainers

caniszczyk avatar Mar 20 '17 21:03 caniszczyk

On Mon, Mar 20, 2017 at 02:07:35PM -0700, Chris Aniszczyk wrote:

@wking it's been renamed: https://github.com/orgs/opencontainers/teams/selinux-maintainers

That page 404s for me (probably because it needs some admin-ish permissions), but I expect you mean that the selinux-maintainers team exists now (and may have before as well). I bumped CommitDate to get a new hash and pushed fa72f6b → 78ece86 to get PullApprove to take another look at this PR, but it's still complaining about a missing selinux-maintainers team on this repo 1. Maybe you forgot to associate that team with this repo? It should be associated with both this repo and the selinux repo.

wking avatar Mar 20 '17 21:03 wking

There is no .pullapprove any more (since commit 008f4e9, PR #61), so this is no longer applicable/needed.

kolyshkin avatar Mar 02 '25 19:03 kolyshkin