image-tools icon indicating copy to clipboard operation
image-tools copied to clipboard

oci-image-tool unpack does not preserve permissions and ownership of entries

Open philips opened this issue 9 years ago • 6 comments

From @glestaris on September 8, 2016 14:7

oci-image-tool does not chmod or chown the extracted files. I wonder if this is something intentional or PR-worthy.

Copied from original issue: opencontainers/image-spec#281

philips avatar Sep 21 '16 02:09 philips

From @wking on September 8, 2016 15:57

On Thu, Sep 08, 2016 at 07:07:39AM -0700, George Lestaris wrote:

oci-image-tool does not chmod or chown the extracted files. I wonder if this is something intentional or PR-worthy.

I think this should be fixed. Unpacking semantics should probably be just like tar, and from tar(1) 1: — --no-same-owner Extract files as yourself (default for ordinary users). --no-same-permissions Apply the user's umask when extracting permissions from the archive (default for ordinary users).

philips avatar Sep 21 '16 02:09 philips

From @glestaris on September 9, 2016 15:15

Thanks @wking, this validates my impression.

I am happy to pick this up and make a PR @opencontainers/image-spec-maintainers.

philips avatar Sep 21 '16 02:09 philips

On Tue, Sep 20, 2016 at 07:47:22PM -0700, Brandon Philips wrote:

From @glestaris on September 9, 2016 15:15

I am happy to pick this up and make a PR @opencontainers/image-spec-maintainers.

This PR has been filed as #3, so we can close this issue.

wking avatar Sep 21 '16 05:09 wking

Happy to close this. I kept it open until the PR gets accepted, but it does not matter that much :)

glestaris avatar Sep 26 '16 08:09 glestaris

...and I just realised I can't close it since I don't own the issue anymore :) @philips feel free to close this

glestaris avatar Sep 26 '16 08:09 glestaris

@wking This issue should stay open as long as #3 isn't merged, #3 should instead have a "Close #17" so this get auto closed when merged. If #17 doesn't end up merged we forgot about this.

runcom avatar Sep 26 '16 08:09 runcom