image-spec icon indicating copy to clipboard operation
image-spec copied to clipboard

Add toml markup for Platform struct

Open kiashok opened this issue 2 years ago • 3 comments

Addresses issue #1073 to add toml markup for Platform struct

kiashok avatar Jun 06 '23 23:06 kiashok

ping on this PR

kiashok avatar Jun 12 '23 22:06 kiashok

(soft) NACK; https://github.com/opencontainers/image-spec/issues/1073#issuecomment-1588238252 (see also https://github.com/pelletier/go-toml/issues/880)

(Soft because I'm still willing to be convinced, but I think we need more spec maintainer opinions to be expressed for this to really move one way or the other)

tianon avatar Jun 23 '23 02:06 tianon

This gets a decline from me as well unless there's a response to https://github.com/opencontainers/image-spec/issues/1073#issuecomment-1589550392 showing why it's needed.

sudo-bmitch avatar Jul 07 '23 23:07 sudo-bmitch

This was brought up in today's meeting (cleaning up old PRs) and the decision was to defer to the TOML default parsing of the struct, or to have the containerd specific requirements happen outside of the OCI spec. Our use of JSON aligns with the rest of the spec that marshals the data into JSON for the descriptors and config blob content. So without a TOML use case here, it didn't make sense to add into OCI directly.

sudo-bmitch avatar May 16 '24 18:05 sudo-bmitch