openconfig
initial commit for leaf setters
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
memo Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g.
I signed it!) and we'll verify it.What to do if you already signed the CLA
Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google.com/docs/cla/#troubleshoot)). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/). * The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).information_source Googlers: Go here for more info. I signed it!
Coverage decreased (-0.2%) to 91.014% when pulling fa4bf01dd8ebb8f4d75c7d4c698b55397175ed64 on adibrastegarnia:add-leaf-setters into 0c7dd99359ddd5a1d00ae064f13934461abd0a7c on openconfig:master.
Coverage decreased (-0.2%) to 91.004% when pulling da31991aaec7e3f191312d14894ad69a67ffda43 on adibrastegarnia:add-leaf-setters into 0c7dd99359ddd5a1d00ae064f13934461abd0a7c on openconfig:master.
@robshakir I started to add leaf setters to the list of helper functions. Would you please take a look so far and give me your comments?
@robshakir
In addition, I am getting a compile error on my end but I don't know how I pass all of the checks:
generator/generator.go:255:23: unknown field 'GenerateLeafSetters' in struct literal of type ygen.GoOpts
I shouldn't get the error because I already defined it but I don't know why it happens
P.S. Resolved
@robshakir I assume that setter function does not return anything if I need to return error or ok or a value please let me know. I tested the patch and it looks like that is working but that would be great if you check it as well.