public icon indicating copy to clipboard operation
public copied to clipboard

QoS Classiers terms should be ordered list

Open rszarecki opened this issue 2 years ago • 1 comments

Currently Classier terms is list with "id" being a key, while "id" is of string type. This do not allow to unambiguisly tell the order of terms, what is critical, since condition of terma may be overlaping. Also adding of ne term would not be possible.

https://github.com/openconfig/public/blob/51e534ee090d8c641fa886ab13422e8e94a68774/release/models/qos/openconfig-qos-elements.yang#L164

It is suggested to replace Id with sequence-Id similiarly to sedulers[seq-id] of uint32 type. And mandate taht terms are evaluated always in ascending order.

rszarecki avatar Jun 26 '23 02:06 rszarecki

I think sequence id is a good approach and as noted there is precedence in the QoS module to use a sequence id.

/qos/scheduler-policies/scheduler-policy/schedulers/scheduler/config/sequence is used for ordering scheduler policy.

dplore avatar Jul 18 '23 17:07 dplore

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

github-actions[bot] avatar May 10 '24 02:05 github-actions[bot]