public icon indicating copy to clipboard operation
public copied to clipboard

Support setting priority for every VRRP track interface

Open lllyfeng opened this issue 2 years ago • 6 comments

Change Scope

  • Currently YANG module can only support set one priority for all VRRP tracked interfaces. It's inconvient if one tracked interface wants to have a different priority. So there should be a list for VRRP track interfaces with two numbers, interface and priority-decrement. OLD:
+--rw interface-tracking
    +--rw config
     |  +--rw track-interface* leafref
     |  +--rw priority-decrement? uint8

NEW:

+--rw interface-tracking
    +--rw track-interface* [interface]
        +--rw interface -> ../config/interface
        +--rw config
        |  +--rw interface? leafref
        |  +--rw priority-decrement? uint8
         +--ro state
            +--ro interface? leafref
            +--ro priority-decrement? uint8
  • non-backwards compatible.

Platform Implementations

lllyfeng avatar Mar 10 '23 03:03 lllyfeng

Major YANG version changes in commit 2e1fe78c3627ab65295636f40324401f04304351: openconfig-if-ip.yang: 3.2.0 -> 4.0.0

OpenConfigBot avatar Mar 10 '23 04:03 OpenConfigBot

Compatibility Report for commit 2e1fe78c3627ab65295636f40324401f04304351: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Mar 10 '23 04:03 OpenConfigBot

Now that I think about it, we are making a breaking change and it might be worth considering adding a possible second action that would shutdown the VRRP instance instead. Perhaps this could be represented as an enum/identity leaf called action and the possible values would be PRIORITY_DECREMENT and DISABLE/SHUTDOWN.

Ref: https://www.arista.com/en/um-eos/eos-varp#xx1153490

rolandphung avatar Aug 02 '23 20:08 rolandphung

Note, does this need to be a breaking change? Since a new container with a different name than the leaf-list is being introduced, the leaf-list could instead be deprecated and the container added. This would make this a non-breaking change and expidite it's merging into the OpenConfig model set.

dplore avatar Aug 02 '23 22:08 dplore

@lllyfeng waiting for your response on this PR. Thanks

dplore avatar Mar 05 '24 17:03 dplore

@lllyfeng please address comments if you would like to proceed. I think the only comment that really should be addressed is the one about deprecation vs. making a breaking change. (https://github.com/openconfig/public/pull/829#issuecomment-1663060498)

dplore avatar May 14 '24 16:05 dplore