public
public copied to clipboard
Add missing version statement to openconfig-extensions
- (M) release/models/openconfig-extensions.yang
- Add missing version statement
Change Scope
- Add missing version statement to openconfig-extensions and increment patch version. This change is backwards compatible.
Platform Implementations
N/A: Missing statement and necessary for consistent behavior, capabilities version reporting, etc..
Compatibility Report for commit c9ab7eed8627aa13656bd796b309ad95ce6dd75e: ⛔ yanglint@SO 1.10.17
Hi Ebben, thanks for the change. I don't think we ever added a version here simply because it seemed quite circular in terms of reference, but I don't think there is any reason not to.
Is there a reason to start this off at a 0.x.y
release? It seems like since it's used throughout it should probably be 1.x.y
at least?
Thanks, r.
Hi Ebben, thanks for the change. I don't think we ever added a version here simply because it seemed quite circular in terms of reference, but I don't think there is any reason not to.
Is there a reason to start this off at a
0.x.y
release? It seems like since it's used throughout it should probably be1.x.y
at least?Thanks, r.
np - I assumed this was the case but there is no harm to reference a definition within the defining module. This is no different than any other statement either prefixed or not.
Up until now, references have been updated in each revision statement without this (so previous was kind of already at 0.5.0 without the extension) so its really a bug fix imo. The move to 1.0.0 I view as orthogonal to this update and would deem this module as stable and ready to move to 1.0.0 which may or may not need additional analysis
@robshakir @dplore - does the last comment make sense? is there anything pending for merge here?
This does seem like a patch/bug-fix for the explicit version statement missing from the 0.5.0 version of the file.