public icon indicating copy to clipboard operation
public copied to clipboard

Add ETH_400GBASE_PSM4 PMD type to openconfig-transport-types

Open atmanmehta opened this issue 3 years ago • 3 comments

[Note: Before this PR can be reviewed please agree to the CLA covering this repo. Please also review the contribution guide - https://github.com/openconfig/public/blob/master/doc/external-contributions-guide.md]

Change Scope

  • Add ETH_400GBASE_PSM4 PMD type to openconfig-transport-types.
  • This change is backward compatible.

Platform Implementations

Adding this since it is already an industry standard.

atmanmehta avatar Sep 21 '22 01:09 atmanmehta

Compatibility Report for commit fa313467c9a117f20e85816c18797961169792db: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Sep 21 '22 01:09 OpenConfigBot

@ejbrever can you review this one for us?

dplore avatar Sep 21 '22 01:09 dplore

In discussing with a @thofmeister it sounds like this 400G PSM4 is really DR4 which we already have here: https://github.com/openconfig/public/blob/master/release/models/optical-transport/openconfig-transport-types.yang#L1042

Is there a reason that wouldn't work? Thanks.

ejbrever avatar Sep 21 '22 19:09 ejbrever

Based on discussions with @ejbrever and @thofmeister, changed the type to ETH_400GMSA_PSM4. PTAL.

atmanmehta avatar Oct 19 '22 20:10 atmanmehta

I'm good with this, but as I'm not nearly as close to optics as tad@, I'll leave the final LGTM to him.

ejbrever avatar Nov 08 '22 01:11 ejbrever

ETH_400GMSA_PSM4 LGTM.

Thanks, Tad

thofmeister avatar Dec 02 '22 23:12 thofmeister

/gcbrun

dplore avatar Dec 03 '22 00:12 dplore