public icon indicating copy to clipboard operation
public copied to clipboard

Add csnp-enable-on-p2p-links leaf to IS-IS global configuration.

Open hariramnat opened this issue 2 years ago • 8 comments

Original Problem

We need to be able to disable CSNP on a global level. This requires specifying csnp enable/disable for p2p links at global IS-IS configuration.

Proposed Solution

Add a csnp-enable-on-p2p-links leaf of type boolean to isis-global-config, set to false by default.

References:

All these references, indicating configuring the interval at an interface level. This model aims at globally enabling/disabling csnp.

Arista: https://www.arista.com/zh/support/toi/eos-4-27-0f/14859-is-is-csnp-generation-interval

Juniper: https://www.juniper.net/documentation/us/en/software/junos/is-is/topics/example/isis-csnp-interval.html

Cisco: https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/iproute_isis/command/irs-cr-book/irs-a1.html#wp1741698451

hariramnat avatar Sep 21 '22 00:09 hariramnat

Compatibility Report for commit 212f9d867f776896cde71ae952563bd2ebd37594: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Sep 21 '22 00:09 OpenConfigBot

Thanks for this contribution. Please check the contributions guide and provide references to at least two implementations. For an example, see #667

dplore avatar Sep 22 '22 00:09 dplore

Done. Added references

hariramnat avatar Sep 22 '22 21:09 hariramnat

Thanks Hariram. @earies @rgwilton @rolandphung @hellt for comment.

dplore avatar Sep 24 '22 00:09 dplore

I have added this to the Sep 27 OpenConfig operators agenda

dplore avatar Sep 24 '22 01:09 dplore

Hey @earies @rgwilton @rolandphung @hellt,

Is there anything else that you would like me to add to this contribution?

hariramnat avatar Sep 27 '22 20:09 hariramnat

This was reviewed in the Sep 27 OC operators meeting with no comments received. We can merge this in 2 weeks (Oct 11, 2022) if there are no objections.

dplore avatar Sep 27 '22 21:09 dplore

Hey Darren,

Have made the default to True now.

Let me know if you have any more changes.

Thanks

hariramnat avatar Oct 14 '22 20:10 hariramnat

/gcbrun

dplore avatar Oct 19 '22 19:10 dplore