public icon indicating copy to clipboard operation
public copied to clipboard

[WiFi] Replace uptime counter with timestamp

Open xavier-contreras opened this issue 2 years ago • 1 comments

Change Scope

This changes the leaf "uptime" under openconfig-ap-manager.yang from a uint32 counter to a new leaf of "up-time" which will be a timeticks64. This is to make telemetry ingestion less churn heavy. The intent of the leaf does not change.

This change is not backwards compatible as a leaf is replaced.

Platform Implementations

oc-types:timeticks64 is used throughout other models and it should be trivial to implement.

xavier-contreras avatar Sep 20 '22 18:09 xavier-contreras

Compatibility Report for commit 229706522c92f4be0794d1f7da0be26b36f8324e: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Sep 20 '22 19:09 OpenConfigBot

Should we move this to the new release model: https://github.com/openconfig/public/blob/master/doc/releases.md ?

If we follow this, would should aim to mark uptime as deprecated and introduce up-time.

jsnyder81 avatar Jan 06 '23 18:01 jsnyder81

Should we move this to the new release model: https://github.com/openconfig/public/blob/master/doc/releases.md ?

If we follow this, would should aim to mark uptime as deprecated and introduce up-time.

Agreed, this is a good example where we can deprecate the leaf to make this change non-breaking.

dplore avatar Jan 11 '23 21:01 dplore

No major YANG version changes in commit 229706522c92f4be0794d1f7da0be26b36f8324e

OpenConfigBot avatar Jan 17 '23 23:01 OpenConfigBot

Should we move this to the new release model: https://github.com/openconfig/public/blob/master/doc/releases.md ? If we follow this, would should aim to mark uptime as deprecated and introduce up-time.

Agreed, this is a good example where we can deprecate the leaf to make this change non-breaking.

Fixed -- guidance did not exist prior to this PR, good to see it documented. I also updated the version to minor increase since this is no longer a breaking change.

xavier-contreras avatar Jan 18 '23 00:01 xavier-contreras

LGTM

jsnyder81 avatar Jan 25 '23 17:01 jsnyder81