public icon indicating copy to clipboard operation
public copied to clipboard

Published 20 hours ago • verified publisher icon openconfig

Correct BFD diagnostic codes per RFC5880/6428

Open earies opened this issue 2 years ago • 3 comments

  • (M) release/models/bfd/openconfig-bfd.yang
    • Add missing codes and adjust value mappings according to RFC

Previously, the enum variants for BFD diagnostic codes missed value (3) per RFC5880. This PR addresses the missing diagnostic code, correcting the subsequent variant values and adding the reserved value (9) per RFC6428.

earies avatar Jul 18 '22 16:07 earies

Compatibility Report for commit b2169582070cde82cb51ed277ae7e5a9852782d3: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Jul 18 '22 16:07 OpenConfigBot

LGTM, will wait for a couple days to merge for any other comments.

dplore avatar Jul 18 '22 17:07 dplore

I am ok with the changes, but as this is technically a yang breaking change due to the enum value changes, should the major version be incremented?

As long as we specify all or no values for the enums I think we are ok. (ie: we should not introduce enums where some values are specified and other are not).

dplore avatar Aug 16 '22 22:08 dplore