public icon indicating copy to clipboard operation
public copied to clipboard

Two reset-trigger mode cannot exist at the same time. The value should not be a key.

Open littlePeppy opened this issue 3 years ago • 3 comments

https://github.com/openconfig/public/blob/7a244a8e3259d3771a8ebef92b38b77e1cbadfdd/release/models/isis/openconfig-isis.yang#L535

littlePeppy avatar Jun 17 '22 08:06 littlePeppy

Hi, I can find reference for a few trigger conditions for ISIS overload reset:

  • configuration
  • timeout
  • startup
  • wait for bgp

It seems it is possible in some implementations to configure more than one of these at the same time?

https://www.cisco.com/c/en/us/support/docs/ip/integrated-intermediate-system-to-intermediate-system-is-is/24509-set-overload-bit.html#topic1

https://www.juniper.net/documentation/us/en/software/junos/is-is/topics/ref/statement/overload-edit-protocols-isis.html

dplore avatar Jun 17 '22 15:06 dplore

image When “set-bit-on-boot“ is true, that means “set-overload-bit on-startup“, the default is used(it means wait-for-system). If you want to choose a tigger mode, then and wait-for-bgp is alternative.

So I think, The two reset-trigger mode cannot exist at the same time. It is consistent with you?

littlePeppy avatar Jun 20 '22 12:06 littlePeppy

An implementation does not have to support more than one mode simultaneously here - but I do think that there are use cases whereby one wants to specify a system timeout and a "wait for BGP". We might choose to model these in this way anyway (i.e., a list) such that this feels a reasonable choice.

Is there an implementation problem here other than validating that this combination might not be allowed in some implementations?

robshakir avatar Jun 21 '22 15:06 robshakir

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

github-actions[bot] avatar May 17 '24 02:05 github-actions[bot]