public icon indicating copy to clipboard operation
public copied to clipboard

Add policy support #594

Open sbarguil opened this issue 3 years ago • 2 comments

To solve #594

sbarguil avatar Mar 01 '22 13:03 sbarguil

Compatibility Report for commit f4f5c797078bee02affbefa794ab2dd5f201f84d: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Mar 01 '22 13:03 OpenConfigBot

i don't think the way that this PR proposes to make this change is compatible with the modelling approach we have for import policies today.

the import policies that are specified in bgp are defined per-neighbour or group, and are not intended to be able to import routes from other protocols. the design for doing that is through table-connections. i.e., to do something like redistribute from is-is to bgp, one must create a table connection between INSTALL_PROTOCOL BGP and INSTALL_PROTOCOL ISIS that then makes these routes available. some systems do this 'by default' but others do not and need 'redistribute XXX' type configuration, so we had to figure whether this should be explicit or not since these are two fundamentally different approaches.

i believe what you're trying to do here is to rely on implicit connections and then define the import policy as to /what/ makes it into ospf, is that correct? i think we need to consider how that can co-exist with the table connections without creating two different ways to do the same thing.

robshakir avatar Jul 30 '22 17:07 robshakir