openconfig
Private VLAN configuration changes to VLAN Yang model
Submitting this on behalf of Cisco as per request from Google team. Private VLAN (a.k.a PVLAN) configuration is introduced as part of VLAN yang file. Kindly review the same.
Snippets from Cisco configuration guide explaining PVLAN,
Using private VLANs provides scalability and IP address management benefits for service providers and Layer 2 security for customers. Private VLANs partition a regular VLAN domain into subdomains. A subdomain is represented by a pair of VLANs: a primary VLAN and a secondary VLAN. A private VLAN can have multiple VLAN pairs, one pair for each subdomain. All VLAN pairs in a private VLAN share the same primary VLAN. The secondary VLAN ID differentiates one subdomain from another.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it
From: "google-cla[bot]" [email protected] Reply-To: openconfig/public [email protected] Date: Wednesday, November 4, 2020 at 6:11 PM To: openconfig/public [email protected] Cc: Madhan Kumar [email protected], Author [email protected] Subject: Re: [openconfig/public] Private VLAN configuration changes to VLAN Yang model (#387)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoothttp://go/cla#troubleshoot (Public versionhttps://opensource.google/docs/cla/#troubleshoot).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
- The email used to register you as an authorized contributor must also be attached to your GitHub accounthttps://github.com/settings/emails.
ℹ️ Googlers: Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fopenconfig%2Fpublic%2Fpull%2F387 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/openconfig/public/pull/387#issuecomment-722080267, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARUJMRZD5PFLCLUETFOZFMTSOICVHANCNFSM4TKYWWHQ.
@googlebot I signed it
From: googlebot [email protected] Reply-To: openconfig/public [email protected] Date: Wednesday, November 4, 2020 at 6:12 PM To: openconfig/public [email protected] Cc: Madhan Kumar [email protected], Author [email protected] Subject: Re: [openconfig/public] Private VLAN configuration changes to VLAN Yang model (#387)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoothttp://go/cla#troubleshoot (Public versionhttps://opensource.google/docs/cla/#troubleshoot).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
- The email used to register you as an authorized contributor must also be attached to your GitHub accounthttps://github.com/settings/emails.
ℹ️ Googlers: Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fopenconfig%2Fpublic%2Fpull%2F387 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/openconfig/public/pull/387#issuecomment-722080270, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARUJMR6IBCMAN7Z4KXNYJLLSOICVJANCNFSM4TKYWWHQ.
Hi @madhankumar76 - Can you please make sure that the linter checks pass here as well? Our linter is publicly available so you should be able to validate this before submitting. Let me know if you need help or directions with that.
Hi @madhankumar76 - Can you please make sure that the linter checks pass here as well? Our linter is publicly available so you should be able to validate this before submitting. Let me know if you need help or directions with that.
I ran this in my repository and it did not produce any error, pyang --strict --lint -p /workspace/openconfig/public/release/models/ openconfig-vlan*
Let me know if this is sufficient or do i need to use any other tool for linter checks?