Added PASSIVE as enum option for mode, it will stop all router advert…

[shasingh27]

…isement and solicitation, it will only receive advertisement and solicitation

Change Scope

• [Please briefly describe the change that is being made to the models.] after the changes from PR https://github.com/openconfig/public/commit/37557d26460d13c7deed03f5448e14497affd544 suppress leaf was deprecated, suppress functionality was basically suppressing the sending of periodic and non-periodic advertisements. it can still receive periodic and non-periodic advertisements

the leaf enable, when introduced: leaf enable { type boolean; default true; description "If set to false, all IPv6 router advertisement functions are disabled. The local system will not transmit router advertisement messages and will not respond to router solicitation messages."; } it stops all the functionality, basically stopping the sending and receiving of both periodic and non-periodic advertisements.

• [Please indicate whether this change is backwards compatible.] YES, this change is backward compatible

• Implementation A: link to documentation and/or implementation output.

• Implementation B: link to documentation and/or implementation output.

https://github.com/openconfig/public/commit/37557d26460d13c7deed03f5448e14497affd544

[Note: If the feature being proposed is new - and something that is being proposed as an enhancement to device functionality, it is sufficient to have reviewers from the producers of two different implementations]. yes

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[shasingh27]

Leaf enable was created exactly for this purpose

https://github.com/openconfig/public/blob/71eae392cc60e24466fe06208dd380686524859e/release/models/interfaces/openconfig-if-ip.yang#L1053-L1061

See also openconfig/featureprofiles#2981 (comment)

There's no need to duplicate this functionality.

suppress leaf was deprecated, suppress functionality was basically suppressing the sending of periodic and non-periodic advertisements. it can still receive periodic and non-periodic advertisements

the leaf enable, when introduced: leaf enable { type boolean; default true; description "If set to false, all IPv6 router advertisement functions are disabled. The local system will not transmit router advertisement messages and will not respond to router solicitation messages."; } it stops all the functionality, basically stopping the sending and receiving of both periodic and non-periodic advertisements.

[LimeHat]

it stops all the functionality, basically stopping the sending and receiving of both periodic and non-periodic advertisements.

how did you come to that conclusion? the description talks only about originating the RAs: unsolicited (periodic) and solicited (non-periodic)

there's no mention of "receiving". in fact, a local system cannot control what it receives.

enable=false is a direct replacement of the previous suppress=true.