public icon indicating copy to clipboard operation
public copied to clipboard

Refactor IS-IS Graceful Restart nodes

Open earies opened this issue 1 year ago • 9 comments

  • (M) release/models/isis/openconfig-isis-lsp.yang
  • (M) release/models/isis/openconfig-isis-routing.yang
  • (M) release/models/isis/openconfig-isis.yang
    • Refactor IS-IS GR leaves according to RFC, remove defaults
    • Removal of non-standard interface-time-expirations leaf

Change Scope

This change involves:

  • Removal of any graceful-restart timer defaults. There are no such defaults agreed upon across implementations and usage can vary per use-case.
  • Addition of units statements to represent correct time unit
  • Refactor grouping names to align w/ the usage (level/system)
  • Removal of interface-time-expirations leaf as there is only 1 referenced implementation. Suggestion would be an augmentation or usage of native modeling in such cases vs. everyone else deviating.
  • Correct description statements/RFC references

This change is backwards incompatible though likely reduced impact due to implementation status.

Platform Implementations

  • RFC compliance
  • Removal of interface-time-expirations leaf as there was only 1 prior implementation reference.

earies avatar Feb 10 '25 19:02 earies

/gcbrun

dplore avatar Feb 19 '25 00:02 dplore

Major YANG version changes in commit dc84807bdf949755cac8a856b39ba56dc0e956af: openconfig-isis-lsp.yang: 1.7.0 -> 2.0.0 openconfig-isis-routing.yang: 1.7.0 -> 2.0.0 openconfig-isis.yang: 1.7.0 -> 2.0.0

OpenConfigBot avatar Feb 19 '25 00:02 OpenConfigBot

@rgwilton @nandanarista @limehat any comments on this one?

dplore avatar Apr 08 '25 16:04 dplore

We are supportive of making this change.

As Ebben suggests, it is non-standard. It is worth noting that we do currently map this, but only at the global level, not on a per interface basis.

rgwilton avatar Apr 30 '25 14:04 rgwilton

@dplore it has been quite a few months on this PR - can we set last call for 2 weeks?

earies avatar Oct 10 '25 16:10 earies

/gcbrun

dplore avatar Oct 10 '25 22:10 dplore

Will review at Oct 14, 2025 OC Operators meeting.

Tree view of changes

module: openconfig-network-instance
   +--rw network-instances
      +--rw network-instance* [name]
         +--rw protocols
         |  +--rw protocol* [identifier name]
         |     +--rw isis
         |     |  +--rw global
         |     |  |  +--rw config
         |     |  |  +--rw graceful-restart
         |     |  |  |  +--rw config
         |     |  |  |  |  +--rw enabled?                      boolean
         |     |  |  |  |  +--rw helper-only?                  boolean
         |     |  |  |  |  +--rw non-planned-only?             boolean
         |     |  |  |  |  +--rw restart-time?                 uint16
         |     |  |  |  |  +--rw interface-timer?              uint16
-        |     |  |  |  |  +--rw interface-time-expirations?   int64
         |     |  |  |  +--ro state
         |     |  |  |     +--ro enabled?                      boolean
         |     |  |  |     +--ro helper-only?                  boolean
         |     |  |  |     +--ro non-planned-only?             boolean
         |     |  |  |     +--ro restart-time?                 uint16
         |     |  |  |     +--ro interface-timer?              uint16
-        |     |  |  |     +--ro interface-time-expirations?   int64

dplore avatar Oct 10 '25 22:10 dplore

/gcbrun

ElodinLaarz avatar Dec 02 '25 16:12 ElodinLaarz

Discussed at the OC Operators Meeting Dec 2nd - Left some comments. We should lean towards making this non-breaking change.

ElodinLaarz avatar Dec 02 '25 17:12 ElodinLaarz